Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-popover): prevent matchMedia call before hydration #2893

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix(sbb-popover): prevent matchMedia call before hydration #2893

merged 1 commit into from
Jul 5, 2024

Conversation

kyubisation
Copy link
Contributor

Closes #2875

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 4, 2024
jeripeierSBB
jeripeierSBB approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 4, 2024
@kyubisation kyubisation merged commit c5bbb96 into main Jul 5, 2024
24 of 25 checks passed
@kyubisation kyubisation deleted the fix-popovere-ssr branch July 5, 2024 07:51
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jul 5, 2024
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: hydration of popover causes problems
2 participants
@kyubisation @jeripeierSBB